Re: Proposal : REINDEX xxx VERBOSE

<div dir="ltr"><div class="gmail_extra"><br />On Wed, May 13, 2015 at 2:49 PM, Sawada Masahiko <<a
href="mailto:sawada.mshk@gmail.com">sawada.mshk@gmail.com</a>>wrote:<br />><br />> On Thu, May 14, 2015 at
12:28AM, Robert Haas <<a href="mailto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>> wrote:<br />> > On
Thu,May 7, 2015 at 6:55 PM, Sawada Masahiko <<a href="mailto:sawada.mshk@gmail.com">sawada.mshk@gmail.com</a>>
wrote:<br/>> >> Sorry, I forgot attach files.<br />> ><br />> > Review comments:<br />> ><br
/>>> - Customarily we use int, rather than uint8, for flags variables.  I<br />> > think we should do that
herealso.<br />> ><br />> > - reindex_index() emits a log message either way, but at DEBUG2 level<br />>
>without VERBOSE and at the INFO level with it.  I think we should skip<br />> > it altogether without
VERBOSE. i.e. if (options & REINDEXOPT_VERBOSE)<br />> > ereport(...)<br />> ><br />> > - The
errmsg()in that function should not end with a period.<br />> ><br />> > - The 000 patch makes a pointless
whitespacechange to tab-complete.c.<br />> ><br />> > - Instead of an enumerated type (ReindexOption) just
use#define to<br />> > define the flag value.<br />> ><br />> > Apart from those fairly minor issues,
Ithink this looks pretty solid.<br />> ><br />><br />> Thank you for reviwing..<br />> All fixed.<br
/>><br/><br /></div><div class="gmail_extra">IMHO we don't need "pg_rusage_init(&ru0)" if the verbose options is
notsetted. Maybe change:<br /><br />+<br />+    pg_rusage_init(&ru0);<br /><br /></div><div
class="gmail_extra">to<br/><br />+<br />+    if (options & REINDEXOPT_VERBOSE)<br />+       
pg_rusage_init(&ru0);<br/></div><div class="gmail_extra"><br /></div><div class="gmail_extra"><br /></div><div
class="gmail_extra">Regards,<br/></div><div class="gmail_extra"><br />--<br />Fabrízio de Royes Mello<br
/>Consultoria/CoachingPostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog: <a
href="http://fabriziomello.github.io">http://fabriziomello.github.io</a><br/>>> Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a><br/>>> Github: <a
href="http://github.com/fabriziomello">http://github.com/fabriziomello</a></div></div>