Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.

Поиск
Список
Период
Сортировка
От Fabrízio de Royes Mello
Тема Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.
Дата
Msg-id CAFcNs+qTDTY-p7Sz-TNr5EM83c8rTh3yFiHHcYhq+3ruBEScbQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
Дерево обсуждения

On Wed, May 22, 2019 at 4:57 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Fabrízio de Royes Mello <fabriziomello@gmail.com> writes:
> > There are some case I missed to force us to use pg_get_publication_tables
> > SRF instead of use pg_publication_rel ??
>
> pg_publication_rel isn't going to provide the correct expansion of
> a FOR ALL TABLES publication, IIUC.
>

You're correct... there are a condition for it in pg_get_publication_tables and FOR ALL TABLES publications doesn't persist anything in pg_publication_rel.  

497         publication = GetPublicationByName(pubname, false);
498         if (publication->alltables)
499             tables = GetAllTablesPublicationRelations();
500         else
501             tables = GetPublicationRelations(publication->oid);

Thanks for clarifying!

Regards,

--
   Fabrízio de Royes Mello         Timbira - http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pgsql: Fix O(N^2) performance issue in pg_publication_tables view.
Следующее
От: Tom Lane
Дата:
Сообщение: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.