Re: Can pg_dump make use of CURRENT/SESSION_USER

Поиск
Список
Период
Сортировка
От Fabrízio de Royes Mello
Тема Re: Can pg_dump make use of CURRENT/SESSION_USER
Дата
Msg-id CAFcNs+qQYi5GspCf8AWqJ++aLRkRycM8iVgF_m0=nqn3rFGgOw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Can pg_dump make use of CURRENT/SESSION_USER  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Ответы Re: Can pg_dump make use of CURRENT/SESSION_USER
Список pgsql-hackers
Дерево обсуждения

On Wed, Apr 29, 2015 at 1:14 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> Fabrízio de Royes Mello wrote:
> >
> > Looking at the patch again I realize the code is very ugly, so I'll rework
> > the patch.
>
> Yes, I think get_object_address should figure out what to do with the
> representation of CURRENT DATABASE directly, rather than having the
> COMMENT code morph from that into a list containing the name of the
> current database.  Please see about changing SECURITY LABEL at the same
> time, if only to make sure that the representation is sane.
>

I have this idea:

1) Add an ObjectAddress field to CommentStmt struct an set it in gram.y

2) In the CommentObject check if CommentStmt->address is InvalidObjectAddress then call get_object_address else use it

Thoughts?

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

В списке pgsql-hackers по дате отправления: