Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED

<div dir="ltr"><div class="gmail_extra"><br />On Wed, Jul 16, 2014 at 3:53 PM, Andres Freund <<a
href="mailto:andres@2ndquadrant.com">andres@2ndquadrant.com</a>>wrote:<br />><br />> On 2014-07-16 20:25:42
+0200,Andres Freund wrote:<br /> > > Hi,<br />> ><br />> > I quickly looked at this patch and I think
there'smajor missing pieces<br />> > around buffer management and wal logging.<br />> ><br />> > a)
Currentlybuffers that are in memory marked as<br /> > >    permanent/non-permanent aren't forced out to
disk/prunedfrom cache,<br />> >    not even when they're dirty.<br />> > b) When converting from a unlogged
toa logged table the relation needs<br /> > >    to be fsynced.<br />> > c) Currently a unlogged table
changedinto a logged one will be<br />> >    corrupted on a standby because its contents won't ever be WAL
logged.<br/>><br />> Forget that, didn't notice that you're setting tab->rewrite = true.<br /> ><br /><br
/>:-)<br/><br />--<br />Fabrízio de Royes Mello<br />Consultoria/Coaching PostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog sobre TI: <a
href="http://fabriziomello.blogspot.com">http://fabriziomello.blogspot.com</a><br/> >> Perfil Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a></div></div>