Re: Fixing memory leaks in postgres_fdw

On Thu, May 29, 2025 at 2:02 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
> > Pushed v5-0001, and here are rebased versions of the other four
> > patches, mostly so that the cfbot knows what is the patch-of-record.
>
> Finally, here's a minimalistic version of the original v1-0001
> patch that I think we could safely apply to fix the DirectModify
> problem in the back branches.  I rejiggered it to not depend on
> inventing MemoryContextUnregisterResetCallback, so that there's
> not hazards of minor-version skew between postgres_fdw and the
> main backend.  This will of course not fix any other PGresult-leakage
> cases that may exist, but I'm content to fix the known problem
> in back branches.
>
> (Patch is labeled .txt so that cfbot doesn't think it's the
> patch-of-record.)
>

Sounds reasonable to me. +1 for going forward with these patches.

--
Matheus Alcantara