Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - Thatis the Question
| От | Matthew Kleiman |
|---|---|
| Тема | Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - Thatis the Question |
| Дата | |
| Msg-id | CAFS4TJZx3C-G35wYZ3mbTrFufGcu8NwHVqsYJ_easdZfLsmiLQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question (Dave Page <dpage@pgadmin.org>) |
| Ответы |
Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - Thatis the Question
|
| Список | pgadmin-hackers |
We are working on this now. Should I open a bug or a feature in redmine to track this work publicly or just keep it in our backlog only?
On Thu, Jun 1, 2017 at 11:11 AM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:--Hi Hackers!We noticed that there have been quite a few Redmine issues that ended up being related to the same function in sqleditor.js. We were wondering if it might be a good idea to extract this function and test it. This would allow us to iterate more quickly and identify potential bugs before they're opened. There have been a few merge conflicts already in this area and without tests it is difficult to resolve these with high confidence.The function in question is the callback for onSelectedRangesChanged. In the latest commit on master (12fa02), it's from line 696 to 773.Sounds sensible. Do you have a proposed patch?Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: