On Fri, Feb 9, 2024 at 7:35 PM Ajin Cherian <itsajin@gmail.com> wrote: > > > > On Tue, Feb 6, 2024 at 5:06 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: >> >> >> I've attached the new version patch set. >> >> Regards, >> >> >> -- >> Masahiko Sawada >> Amazon Web Services: https://aws.amazon.com > > > Thanks for the patch. I reviewed that patch and did minimal testing and it seems to show the speed up as claimed. Some minor comments:
Thank you for the comments!
> patch 0001: > > +static void > +bh_enlarge_node_array(binaryheap *heap) > +{ > + if (heap->bh_size < heap->bh_space) > + return; > > why not check "if (heap->bh_size >= heap->bh_space)" outside this function to avoid calling this function when not necessary? This check was there in code before the patch.
Agreed.
> > patch 0003: > > +/* > + * The threshold of the number of transactions in the max-heap (rb->txn_heap) > + * to switch the state. > + */ > +#define REORDE_BUFFER_MEM_TRACK_THRESHOLD 1024 > > Typo: I think you meant REORDER_ and not REORDE_
Fixed.
These comments are addressed in the v4 patch set I just shared[1].
These changes look good to me. I've done some tests with a few varying levels of subtransaction and I could see that the patch was at least 5% better in all of them.