Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
| От | Ajin Cherian |
|---|---|
| Тема | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |
| Дата | |
| Msg-id | CAFPTHDa_3nEzNUu8WfOttTM8+XS5cT0OnBabN=fGRzT8A0w7iQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions (Dilip Kumar <dilipbalaut@gmail.com>) |
| Ответы |
Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
|
| Список | pgsql-hackers |
On Fri, Jul 10, 2020 at 3:11 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
With your changes sometimes due to incomplete toast
changes, if it can not pick the largest top txn for streaming it will
hang forever in the while loop, in that case, it should go for
spilling.
while (rb->size >= logical_decoding_work_mem * 1024L)
{
/*
* Pick the largest transaction (or subtransaction) and evict it from
* memory by streaming, if supported. Otherwise, spill to disk.
*/
if (ReorderBufferCanStream(rb) &&
(txn = ReorderBufferLargestTopTXN(rb)) != NULL)
Which is this condition (of not picking largest top txn)? Wouldn't ReorderBufferLargestTopTXN then return a NULL? If not, is there a way to know that a transaction cannot be streamed, so there can be an exit condition for the while loop?
regards,
Ajin Cherian
Fujitsu Australia
В списке pgsql-hackers по дате отправления: