Re: Truncate in synchronous logical replication failed
| От | Ajin Cherian |
|---|---|
| Тема | Re: Truncate in synchronous logical replication failed |
| Дата | |
| Msg-id | CAFPTHDaAjR7F86MJ7eOprXMekEpV21gMSfZW_58t+c+cAOzysw@mail.gmail.com обсуждение исходный текст |
| Ответ на | RE: Truncate in synchronous logical replication failed ("osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>) |
| Ответы |
RE: Truncate in synchronous logical replication failed
|
| Список | pgsql-hackers |
No problem. Thank you for updating the patch.
I've conducted some cosmetic changes. Could you please check this ?
That's already applied by pgindent.
I executed RT for this and made no failure.
Just in case, I executed 010_truncate.pl test 100 times in a tight loop,
which also didn't fail.
I reviewed the patch, ran make check, no issues. One minor comment:
Could you add the comment similar to RelationGetIndexAttrBitmap() on why the redo, it's not very obvious
to someone reading the code, why we are refetching the index list here.
+ newindexoidlist = RelationGetIndexList(relation);
thanks,
Ajin Cherian
Fujitsu Australia
В списке pgsql-hackers по дате отправления: