Re: [pgAdmin4][Patch]: Psycopg3 Fixes
От | Khushboo Vashi |
---|---|
Тема | Re: [pgAdmin4][Patch]: Psycopg3 Fixes |
Дата | |
Msg-id | CAFOhELfQdnPVVBL_PoL_6abvR-25+OdLEaBxx3=sp9atZHaaaQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgAdmin4][Patch]: Psycopg3 Fixes (Akshay Joshi <akshay.joshi@enterprisedb.com>) |
Список | pgadmin-hackers |
Hi Akshay,
Please find the patch with the fixes.
On Fri, Oct 21, 2022 at 8:58 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi KhushbooI think you forgot to add the python version check in the requirements.txtpsycopg2==2.9.*psycopg==3.1.0
Fixed.
Builds are still failing.Do we have checks inside the code that if psycopg3 is installed then call the API of psycopg3 else fallback to psycopg2? If not then we should add such checks.
I have put the check in the config file, if the python version is < 3.7 then use psycopg2 otherwise psycopg3.
PEP8 fixes are done.
Thanks,
Khushboo
On Fri, Oct 21, 2022 at 8:44 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied to the psycopg3 branchOn Thu, Oct 20, 2022 at 2:40 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch which includes the inclusion of psycopg2 again. So, psycopg2 and psycopg3 both are supported. Also, it fixes some of the test cases which were failing. The debugger test cases fixes work is in progress.Thanks,Khushboo--
Akshay Joshi
Principal Software Architect
+91 9767888246
--
Akshay Joshi
Principal Software Architect
+91 9767888246
Вложения
В списке pgadmin-hackers по дате отправления: