Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

Поиск
Список
Период
Сортировка
От Khushboo Vashi
Тема Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint
Дата
Msg-id CAFOhELebuQXDKz850J0QVF8wywLXG1EShktTkU19wfgxWbYYLQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Akshay,

Please find the attached updated patch.

On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Test case are working fine, some minor review comments:
  • Scenario name "Create/Alter Exclusion Constraint" repeating twice instead of that it should be more understandable.
  • File name should not be like "create/alter_exclusion_constraint_1.sql" it should be like 'alter_comment.sql'.

Fixed.

Thanks,
Khushboo 
On Mon, Aug 5, 2019 at 12:30 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the RE-SQL tests of the Exclusion constraint node with some bug fixes in SQL.

Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: pgAdmin 4 commit: Update Chinese translation.
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Add Reverse Engineered SQL tests for Exclusion Constr