Re: [pgAdmin][RM1802] ERD Tool (Beta)

Hi Aditya,

The functionalities and the code looks good to me, however some of the comments as below:

Correct the comments at some places (3 occurrences found  in /erd/__init__.py)  which mention Schema diff instead of ERD.

Remove the unused imports (for ex bad_request) in /erd/__init__.py
Remove commented code

# req_args = request.args
# if ('recreate' in req_args and
#     req_args['recreate'] == '1'):
#     connect = False

TableNode.jsx, below two lines can be combined.

import { PortModelAlignment, DefaultNodeModel } from '@projectstorm/react-diagrams';
import { PortWidget } from '@projectstorm/react-diagrams';

onImageClick function in BodyWidget.jsx is no use I think, so it should be removed.

I got some console errors while adding/editing tables. Refer to the attached screenshot.
In the column Edit Mode, while deleting the primary key, it gives the error, which does not go away with any further modifications.
While generating the SQL, if the server is disconnected, a proper error message should be thrown, right now some server side error is coming. 
Please remove ... from the menu title (New ERD Project(Beta)...) as it is not opening a dialog.
For large data sets, generate ERD hangs.
Opening the ERD panel in a new window is not working, it opens in the same tab even if you have set the Preference "Open in new browser tab" to True.
No shortcut is provided to open the ERD Tool.
SonarQube fixes required.

Suggestion:

While removal of the FK link, If any of the table is selected, it is being deleted with FK link.
Either we should warn the user OR make 2 different buttons for FK removal and table removal as the user may be confused if the selected table is also removed with the FK.

Observations: