Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user todisable alertifyjs and acitree animations
| От | Khushboo Vashi |
|---|---|
| Тема | Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user todisable alertifyjs and acitree animations |
| Дата | |
| Msg-id | CAFOhELcWPHRxj-wqR5pruezN2K8j6AS5RzAPB4LB=RJkXeu8WA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user todisable alertifyjs and acitree animations (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>) |
| Список | pgadmin-hackers |
Hi Joao,
On Tue, Mar 27, 2018 at 12:12 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,Looks like you have a typo on your CSS where it reads 'zoomeIn' it should be 'zoomIn'.
Thanks, I have sent the updated patch.
Also setting more parameters into the window, in our experience, is never good, so maybe it is time to create a real settings cache that can retrieve from the backend the settings, like this one.
We already have a cache for preferences, so I have used that in the updated patch.
ThanksVictoria & Joao
Thanks,
Khushboo
On Mon, Mar 26, 2018 at 8:38 AM Dave Page <dpage@pgadmin.org> wrote:HiOn Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix RM #1978: Add an option to allow user to disable alertifyjs and acitree animations.I think these really need to be per-user settings, not per-installation.. Whether or not animations are shown is really a matter of personal taste and circumstance.Thanks.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: