Re: Move catalog toast table and index declarations
| От | John Naylor |
|---|---|
| Тема | Re: Move catalog toast table and index declarations |
| Дата | |
| Msg-id | CAFBsxsEDVn28qa=f9Q_q6WOhtpDudUrKZEcD=1YXaseALnyNWA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Move catalog toast table and index declarations (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>) |
| Ответы |
Re: Move catalog toast table and index declarations
|
| Список | pgsql-hackers |
On Thu, Oct 22, 2020 at 6:21 AM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
> [v1]
Hi Peter,
This part created a syntax error:
--- a/src/include/catalog/unused_oids
+++ b/src/include/catalog/unused_oids
@@ -28,7 +28,7 @@ chdir $FindBin::RealBin or die "could not cd to $FindBin::RealBin: $!\n";
use lib "$FindBin::RealBin/../../backend/catalog/";
use Catalog;
-my @input_files = (glob("pg_*.h"), qw(indexing.h));
+my @input_files = (glob("pg_*.h");
+++ b/src/include/catalog/unused_oids
@@ -28,7 +28,7 @@ chdir $FindBin::RealBin or die "could not cd to $FindBin::RealBin: $!\n";
use lib "$FindBin::RealBin/../../backend/catalog/";
use Catalog;
-my @input_files = (glob("pg_*.h"), qw(indexing.h));
+my @input_files = (glob("pg_*.h");
Style: In genbki.h, "extern int no_such_variable" is now out of place. Also, the old comments like "The macro definitions are just to keep the C compiler from spitting up." are now redundant in their new setting.
The rest looks good to me. unused_oids (once fixed), duplicate_oids, and renumber_oids.pl seem to work fine.
В списке pgsql-hackers по дате отправления: