Re: Typo in pg_db_role_setting.h

On Mon, Aug 1, 2022 at 9:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> John Naylor <john.naylor@enterprisedb.com> writes:
> > You are correct, but I wonder if it'd be better to just drop the comment
> > entirely. I checked a couple other random headers with function
> > declarations and they didn't have such a comment, and it's kind of obvious
> > what they're for.
>
> Some places have these, some don't.  It's probably more useful where
> a header foo.h is declaring functions that aren't in the obviously
> corresponding foo.c file, or live in multiple files.  In this case
> I agree it's not adding much.

I somehow forgot that just yesterday I working on a project that will possibly add a declaration to every catalog header for tuple deforming. In that case, we will want to keep existing comments and possibly add more. In the meantime, I'll go just apply the correction.

--
John Naylor
EDB: http://www.enterprisedb.com