On Mon, Feb 13, 2012 at 6:41 PM, Kris Jurka <books@ejurka.com> wrote:
> On Mon, 13 Feb 2012, Dave Cramer wrote:
>> Thanks for the patch. I've had some time to look at it. One problem I
>> am running into is creating a test case for it.
>>
>> Currently all of our test code is in the test.org.postgresql....
>> package(s) however I can't get access to one of the protected methods
>> from there.
>
> Are you confusing protected with package private? Changing the test
> package won't magically give you access to a protected method.
Actually it will :)
Florent
>
>> I'm thinking we should move all of the test code into
>> org.postgresql.... package and drop the test. This would give us the
>> ability to create unit tests on more methods
>>
>
> The easier approach is just to make more internal methods public. Since
> everyone is really just dealing the standard java.sql interfaces, I don't
> think we'd really be risking over-exposing driver internals.
>
> Kris Jurka
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
--
Florent Guillaume, Director of R&D, Nuxeo
Open Source, Java EE based, Enterprise Content Management (ECM)
http://www.nuxeo.com http://www.nuxeo.org +33 1 40 33 79 87