Re: Use RELATION_IS_OTHER_TEMP where possible

Поиск
Список
Период
Сортировка
От Ashutosh Bapat
Тема Re: Use RELATION_IS_OTHER_TEMP where possible
Дата
Msg-id CAExHW5v+eWp0dVg4e-_d9-7Z4HSQYKK6iZ5JsFeHyBK-WGHE_w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Use RELATION_IS_OTHER_TEMP where possible  (Junwang Zhao <zhjwpku@gmail.com>)
Ответы Re: Use RELATION_IS_OTHER_TEMP where possible
Список pgsql-hackers


On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
Hi Nathan,

On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart
<nathandbossart@gmail.com> wrote:
>
> On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote:
> > All other files perform this check using RELATION_IS_OTHER_TEMP.
> > Should we update tablecmds.c to do the same for consistency?
>
> Seems like a good idea.

Thanks for the comment.

I have attached a patch with the proposed changes.

LGTM. I looked at other instances of is_localtemp, but none of them have (relation)->rd_rel->relpersistence == RELPERSISTENCE_TEMP there. Your patch has covered all the existing ones. 

--
Best Wishes,
Ashutosh Bapat

В списке pgsql-hackers по дате отправления: