Re: Avoid incorrect allocation in buildIndexArray

Поиск
Список
Период
Сортировка
От Ranier Vilela
Тема Re: Avoid incorrect allocation in buildIndexArray
Дата
Msg-id CAEudQAr=855MX0uedcSOZ7LB1yEtrz1zeyD5JH-xJ-QT6Rdmiw@mail.gmail.com
обсуждение исходный текст
Ответ на Avoid incorrect allocation in buildIndexArray  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers

On Fri, Sep 11, 2020 at 1:39 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> Looking at a pg_dump patch I realized that when we call buildIndexArray without
> having found objects to index, we still call pg_malloc with zero which in turn
> mallocs 1 byte. The byte in question is of course negligable, but it does seem
> cleaner to return early with NULL instead of returning an empty allocation
> which doesn't actually contain an index.
>
> Any reason not to bail early as per the attached?

+1

Since, it is protecting from invalid entries.
numObjs is int, the better it would be then.
+ if (numObjs <= 0)
+ return NULL;
+

regards,
Ranier Vilela

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Julien Rouhaud
Дата:
Сообщение: Re: Avoid incorrect allocation in buildIndexArray
Следующее
От: Magnus Hagander
Дата:
Сообщение: pg_service.conf file with iso-8859-1 parameters