Re: PG compilation error with Visual Studio 2015/2017/2019

Thanks for the review comments.

On Tue, Apr 14, 2020 at 9:12 PM Ranier Vilela <ranier.vf@gmail.com> wrote:

>>I m still working on testing this patch. If anyone has Idea please suggest.

I still see problems with this patch.

1. Variable loct have redundant initialization, it would be enough to declare so: _locale_t loct;

2. Style white space in variable rc declaration.

3. Style variable cp_index can be reduced.

if (tmp != NULL) {
   size_t cp_index;

cp_index = (size_t)(tmp - winlocname);
strncpy(loc_name, winlocname, cp_index);
loc_name[cp_index] = '\0';

4. Memory leak if _WIN32_WINNT >= 0x0600 is true, _free_locale(loct); is not called.

I resolved the above comments.

 

5. Why call _create_locale if _WIN32_WINNT >= 0x0600 is true and loct is not used?

_create_locale can take bigger input than GetLocaleInfoEx. But we are interested in

language[_country-region[.code-page]]. We are using _create_locale to validate

the given input. The reason is we can't verify the locale name if it is appended with

code-page by using GetLocaleInfoEx. So before parsing, we verify if the whole input

locale name is valid by using _create_locale. I hope that answers your question.