>> We would be in serious trouble if RelationReloadNailed() could be >> called for a non-existing relation. Wouldn't Assert() be more >> appropriate? > > IMO, I think no. > > In all paths, this check is done, why would this be the only exception?
We use Asserts() for cases that shouldn't happen in practice for performance reasons.
If you are concerned about performance in this case,
you can rest assured.
Since this code doesn't crash.
No, you can't be sure.
I suspect this is one of such cases. Unless you are aware of a specific scenario that makes the code crash of course.