Re: Fix wrong filename in header comment of gin_tuple.h
| От | Chao Li |
|---|---|
| Тема | Re: Fix wrong filename in header comment of gin_tuple.h |
| Дата | |
| Msg-id | CAEoWx2mkxKsuUAd7NXVqOCa3udk6OSvjTw0bDtBmQogLyvqs4g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Fix wrong filename in header comment of gin_tuple.h (David Rowley <dgrowleyml@gmail.com>) |
| Ответы |
Re: Fix wrong filename in header comment of gin_tuple.h
|
| Список | pgsql-hackers |
I quickly created a Python script and captured one more in rewrite/rowsecurity.c. The file put filename reference in a different format than other files:
```
diff --git a/src/backend/rewrite/rowsecurity.c b/src/backend/rewrite/rowsecurity.c
index 4dad384d04d..3d6b6ba177b 100644
--- a/src/backend/rewrite/rowsecurity.c
+++ b/src/backend/rewrite/rowsecurity.c
@@ -1,5 +1,5 @@
/*
- * rewrite/rowsecurity.c
+ * rowsecurity.c
* Routines to support policies for row-level security (aka RLS).
*
* Policies in PostgreSQL provide a mechanism to limit what records are
@@ -31,6 +31,9 @@
*
* Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
+ *
+ * IDENTIFICATION
+ * src/backend/rewrite/rowsecurity.c
*/
index 4dad384d04d..3d6b6ba177b 100644
--- a/src/backend/rewrite/rowsecurity.c
+++ b/src/backend/rewrite/rowsecurity.c
@@ -1,5 +1,5 @@
/*
- * rewrite/rowsecurity.c
+ * rowsecurity.c
* Routines to support policies for row-level security (aka RLS).
*
* Policies in PostgreSQL provide a mechanism to limit what records are
@@ -31,6 +31,9 @@
*
* Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
+ *
+ * IDENTIFICATION
+ * src/backend/rewrite/rowsecurity.c
*/
```
Please see if this one should be fixed as well. Attached is the patch file as shown above.
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/
https://www.highgo.com/
On Mon, Sep 22, 2025 at 9:42 AM David Rowley <dgrowleyml@gmail.com> wrote:
On Mon, 22 Sept 2025 at 12:57, Richard Guo <guofenglinux@gmail.com> wrote:
>
> On Mon, Sep 22, 2025 at 9:53 AM David Rowley <dgrowleyml@gmail.com> wrote:
> > I was just working on a script to find others and it highlighted a
> > bunch more. Do you still want to do this one, or should I take them
> > all in one fell swoop?
>
> Makes sense to handle them all together. Feel free to take this one
> as part of the larger cleanup.
Thanks.
"script" didn't amount to much more than running:
git grep "^\s\*\s.*\.[ch]$" -- *.[ch] | sed -r "s/ \*\s{1,}(.*)/\1/"
and then filtering every line where the text left of the ':' didn't
end in the text right of the ':'. There are about 287 lines out of
4302 lines that don't match that. So a quick eyeball scan of the 287
lines seemed to work to check for abnormalities. Almost all of the
remainder are just mentioning a filename in a sentence rather than for
the identification related stuff.
Pushed the found abnormalities, which included Chao's
David
Вложения
В списке pgsql-hackers по дате отправления: