Re: [PATCH] fix for C4141 warning on MSVC
| От | Thomas Munro |
|---|---|
| Тема | Re: [PATCH] fix for C4141 warning on MSVC |
| Дата | |
| Msg-id | CAEepm=1AOYEhYZ2NRow8A7FCrRgy-6a=8h=8FnZRWbZ1P_YZuA@mail.gmail.com обсуждение исходный текст |
| Ответ на | [PATCH] fix for C4141 warning on MSVC (Michail Nikolaev <michail.nikolaev@gmail.com>) |
| Ответы |
Re: [PATCH] fix for C4141 warning on MSVC
|
| Список | pgsql-hackers |
On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev <michail.nikolaev@gmail.com> wrote: > Just very small fix for C4141 warning > (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4141). > > Also could be viewed on Github - > https://github.com/michail-nikolaev/postgres/commit/38a590a00110a4ea870d625470e4c898e5ad79aa > > Tested both MSVC and gcc builds. Thanks. This is similar to the fix I proposed over here: https://www.postgresql.org/message-id/CAEepm%3D2iTKvbebiK3CdoczQk4_FfDt1EeU4c%2BnGE340JH7gQ0g%40mail.gmail.com Two differences: 1. I also fixed a warning from antique GCC which didn't understand this magic. 2. You also defined it as plain old "inline" for unknown compilers. Perhaps we should combine these? -- Thomas Munro http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: