Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

On Sat, Sep 9, 2017 at 10:23 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Sat, Sep 9, 2017 at 9:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <rhaas@postgresql.org> writes:
>>> Allow a partitioned table to have a default partition.
>>
>> Early buildfarm returns not good.
>>
>> It passes here, so the problem isn't obvious.
>
> map_partition_varattnos() doesn't always write to *found_whole_row, so
> it's uninitialised here in generate_partition_qual():
>
>     result = map_partition_varattnos(result, 1, rel, parent,
>                                      &found_whole_row);
>     /* There can never be a whole-row reference here */
>     if (found_whole_row)
>         elog(ERROR, "unexpected whole-row reference found in partition key");

Hmm, no.  I take that back.

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers