Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?
Дата
Msg-id CAEepm=0-FFs06HNmVpbt=UxTUbi=cjSw0X4oKmr9_Rw-zUWO=g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Obsolete use of volatile in walsender.c, walreceiver.c, walreceiverfuncs.c?  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
On Wed, Oct 7, 2015 at 8:52 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Oct 1, 2015 at 11:01 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>>> Right, see attached.
>>
>> It seems to me that we could as well simplify checkpoint.c and
>> logical.c. In those files volatile casts are used as well to protect
>> from reordering for spinlock operations. See for example 0002 on top
>> of 0001 that is Thomas' patch.
>
> These patches look good to me, so I have committed them.

Thanks.  Also, spin.h's comment contains an out of date warning about
this.  Here's a suggested fix for that, and a couple more volatrivia
patches.

--
Thomas Munro
http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Langote
Дата:
Сообщение: Re: Fix unclear comments in tablecmds.c
Следующее
От: Noah Misch
Дата:
Сообщение: Re: Parallel Seq Scan