Re: Eliminating PD_ALL_VISIBLE, take 2

<div dir="ltr"><div class="gmail_extra"><br /><br /><div class="gmail_quote">On 10 June 2013 00:17, Jeff Davis <span
dir="ltr"><<ahref="mailto:pgsql@j-davis.com" target="_blank">pgsql@j-davis.com</a>></span> wrote:<br
/><blockquoteclass="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex"><divclass="im">On Thu, 2013-05-30 at 10:07 -0700, Jeff Davis wrote:<br /> > >
Cometo think of it, even without the torn page & checksum issue, do we<br /> > > really want to actively
clearthe all-visible flags after upgrade?<br /><br /></div>Removed that from the patch and rebased. I think the best
approachis to<br /> remove the bit opportunistically when we're already dirtying the page<br /> for something else.<br
/><br/> However, right now, there is enough skepticism of the general approach<br /> in this patch (and enough related
proposals)that I'll leave this to be<br /> resolved if and when there is more agreement that my approach is a good<br
/>one.<br /><br /></blockquote></div><div class="gmail_default" style="font-family:trebuchet
ms,sans-serif;font-size:small;color:rgb(0,0,0)"><br/>Did some basic checks on this patch. List-wise feedback below.<br
/><br/>- Cleanly applies to Git-Head: Yes (Some offsets, but thats probably because of delay in review)<br /> -
DocumentationUpdated: No. (Required?)<br />- Tests Updated: No. (Required?)<br />- All tests pass: Yes<br />- Does it
Work: ???<br /><br />- Any visible issues: No<br />- Any compiler warnings: No<br /><br />- Others: <br />Number of
uncoveredlines: Reduced by 167 lines<br /><br />Robins Tharakan<br /></div><br /></div></div>