Re: Patch to add regression tests for SCHEMA
| От | Robins Tharakan |
|---|---|
| Тема | Re: Patch to add regression tests for SCHEMA |
| Дата | |
| Msg-id | CAEP4nAyEJQp1VF8aJq0nknT8x+KFy8rLagBgpyv04xENhDYmrg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Patch to add regression tests for SCHEMA (Fabien COELHO <coelho@cri.ensmp.fr>) |
| Ответы |
Re: Patch to add regression tests for SCHEMA
Re: Patch to add regression tests for SCHEMA |
| Список | pgsql-hackers |
Hi,
Please find attached an updated patch with the said changes.
I'll try to update the other patches (if they pertain to this feedback) and update on their respective threads (as well as on Commitfest).
--
Robins Tharakan
On 8 May 2013 13:01, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
Dear Robins,Short review about this version of the patch:Here is an updated patch that uses different schema / role names for
different tests (as per commitfest site feedback).
This patch work for me.
This test is a good thing and allows schema to be thoroughly tested, including corner cases which must fail because of errors or permissions.
Two remarks:
- test 2 bis: why name 'pg_asdf'? why not 'pg_schema_sch<some number>'
to be homogeneous with other tests?
- test 3: why not WHERE schema_name='schema_sch3' instead of two
negative comparisons? ISTM that if for some reason in the future a new
schema name is added, the test will fail.
--
Fabien.
Вложения
В списке pgsql-hackers по дате отправления: