Re: Add more regression tests for CREATE OPERATOR
| От | Robins Tharakan |
|---|---|
| Тема | Re: Add more regression tests for CREATE OPERATOR |
| Дата | |
| Msg-id | CAEP4nAxmBPSo6Ca1B8VUptUeq+cSjRCrnB52kwScJds86NpH8A@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Add more regression tests for CREATE OPERATOR (Robins Tharakan <tharakan@gmail.com>) |
| Ответы |
Re: Add more regression tests for CREATE OPERATOR
Re: Add more regression tests for CREATE OPERATOR |
| Список | pgsql-hackers |
Hi Szymon,
The commented out test that you're referring to, is an existing test (not that I added or commented). I was going to remove but interestingly its testing a part of code where (prima-facie) it should fail, but it passes (probably why it was disabled in the first place)
--
The commented out test that you're referring to, is an existing test (not that I added or commented). I was going to remove but interestingly its testing a part of code where (prima-facie) it should fail, but it passes (probably why it was disabled in the first place)
!
So technically I hope this regression patch I submitted could go through since this feedback isn't towards that patch, but in my part I am quite intrigued about this test (and how it passes) and probably I'd get back on this thread about this particular commented out test in question, as time permits.
--
Robins Tharakan
On 25 June 2013 04:12, Robins Tharakan <tharakan@gmail.com> wrote:
Thanks a ton Szymon (for a reminder on this one).As a coincidental turn of events, I have had to travel half way across the world and am without my personal laptop (without a linux distro etc.) and just recovering from a jet-lag now.I'll try to install a VM on a make-shift laptop and get something going to respond as soon as is possible.Thanks--Robins Tharakan--Robins TharakanOn 17 June 2013 05:19, Szymon Guz <mabewlun@gmail.com> wrote:On 23 May 2013 00:34, Robins Tharakan <tharakan@gmail.com> wrote:--Hi,Please find attached a patch to take code-coverage of CREATE OPERATOR (src/backend/commands/operatorcmds.c) from 56% to 91%.Any and all feedback is welcome.--Robins Tharakan
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersHi,there is one commented out test. I think it should be run, or deleted. There is no use of commented sql code which is not run.What do you think?regards,Szymon
В списке pgsql-hackers по дате отправления: