Re: Patch to add regression tests for SCHEMA
| От | robins |
|---|---|
| Тема | Re: Patch to add regression tests for SCHEMA |
| Дата | |
| Msg-id | CAEP4nAxkAj71Gm5bPanxyRPWVSS2NhK4gvdkG0crCo7bV2hQvQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Patch to add regression tests for SCHEMA (Alvaro Herrera <alvherre@2ndquadrant.com>) |
| Ответы |
Re: Patch to add regression tests for SCHEMA
|
| Список | pgsql-hackers |
Thanks Alvaro.
Since the tests were running fine, I didn't bother with elaborate names, but since you're concerned guess I'll make that change and re-submit.
And yes, I've already submitted (to Commitfest) another patch related to regression tests for SEQUENCE.
Would submit the SCHEMA patch once the above change is done.
--
Robins
On 18 March 2013 09:42, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
robins escribió:> Hi,I think you should use more explicit names for shared objects such as
>
> Please find attached a patch to take 'make check' code-coverage of SCHEMA
> from 33% to 98%.
>
> Any feedback is more than welcome.
roles -- i.e. not "r1" but "regression_user_1" and so on. (But be
careful about role names used by other tests). The issue is that these
tests might be run in a database that contains other stuff; certainly we
don't want to drop or otherwise affect previously existing roles.I think separate patches is better. Are you adding these patches to the
> p.s.: I am currently working on more regression tests (USER / VIEW /
> DISCARD etc). Please let me know if I need to post these as one large
> patch, instead of submitting one patch at a time.
upcoming commitfest, for evaluation? https://commitfest.postgresql.org
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
В списке pgsql-hackers по дате отправления: