Re: [HACKERS] psql - add ability to test whether a variable exists
| От | Robins Tharakan |
|---|---|
| Тема | Re: [HACKERS] psql - add ability to test whether a variable exists |
| Дата | |
| Msg-id | CAEP4nAwUqpAdpMmmQbpt7CbY+PKT-PRSskZyvrjYvwzVPyb=Yg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [HACKERS] psql - add ability to test whether a variable exists (Fabien COELHO <coelho@cri.ensmp.fr>) |
| Ответы |
Re: [HACKERS] psql - add ability to test whether a variable exists
|
| Список | pgsql-hackers |
Hi Fabien,
I was able to test the functionality (which seemed to work fine) and fed in my comment to assist anyone else reviewing this patch (and intentionally let it's state as 'Needs Review').
While trying to provide my feedback, on hindsight I should have been more detailed about what I didn't test. Being my first review, I didn't understand that not checking a box meant 'failure'. For e.g. I read the sgml changes, which felt okay but didn't click 'Passed' because my env wasn't setup properly.
I've set this back to 'Needs Review' because clearly needs it.
Apologies for the noise here.
-
robins
robins
On 20 September 2017 at 16:18, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
Hello Robins,
Thanks for the review.The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Where ?Spec compliant: not tested
Documentation: tested, failed
Where ? I just regenerated the html doc on the patch without a glitch.The patch applies cleanly and compiles + installs fine (although am unable to do installcheck-world on my Cygwin setup). This is how the patch works on my setup.
$ /opt/postgres/reviewpatch/bin/psql -U postgres -h localhost
psql (11devel, server 9.6.1)
Type "help" for help.
postgres=# \set i 1
postgres=# \if :{?i}
postgres=# \echo 'testing'
testing
postgres=# \endif
postgres=# \if :{?id}
postgres@# \echo 'testing'
\echo command ignored; use \endif or Ctrl-C to exit current \if block
postgres@# \endif
postgres=#
ISTM that this is the expected behavior.
In the first case, "i" is defined, so the test is true and the echo echoes.
In the second case, "id" is undefined, the test is false and the echo is skipped.
I do not understand why you conclude that the feature "failed".
--
Fabien.
В списке pgsql-hackers по дате отправления: