Le mer. 31 mars 2021 à 02:37, Michael Paquier <michael@paquier.xyz> a écrit :
On Tue, Mar 30, 2021 at 12:02:45PM +0900, Michael Paquier wrote: > Okay. So I have looked at that stuff in details, and after fixing > all the issues reported upthread in the code, docs and tests I am > finishing with the attached. The tests have been moved out of > src/bin/pg_dump/ to src/test/modules/test_pg_dump/, and include both > positive and negative tests (used the trick with plpgsql for the > latter to avoid the dump of the extension test_pg_dump or any data > related to it).
I have double-checked this stuff this morning, and did not notice any issues. So, applied.
Thanks a lot. I've seen your email yesterday but had too much work going on to find the time to test your patch. Anyway, I'll take a look at how you coded the TAP test to better understand that part and to be able to do it myself next time.