Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Tue, Mar 15, 2022 at 10:17 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Tue, Mar 15, 2022 at 12:30 PM Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
> >
> > Few comments on the latest patch:
> >
> > -               /* We need to construct the pathname for this database */
> > -               dbpath = GetDatabasePath(xlrec->dbid, xlrec->tsid);
> > +               if (xlrec->dbid != InvalidOid)
> > +                       dbpath = GetDatabasePath(xlrec->dbid, xlrec->tsid);
> > +               else
> > +                       dbpath = pstrdup("global");
> >
> > Do we really need this change? Is GetDatabasePath() alone not capable
> > of handling it?
>
> Well, I mean, that function has a special case for
> GLOBALTABLESPACE_OID, but GLOBALTABLESPACE_OID is 1664, and InvalidOid
> is 0.
>

Wouldn't this be true only in case of a shared map file (when dbOid is
Invalid and tblspcOid is globaltablespace_oid) or am I missing
something?

--
With Regards,
Ashutosh Sharma.