Re: [HACKERS] pg_basebackup fails on Windows when using tablespace mapping

On Tue, Jun 27, 2017 at 6:36 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Jun 27, 2017 at 7:46 PM, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
>> I am still seeing the issue with the attached patch. I had a quick
>> look into the patch. It seems to me like you have canonicalized the
>> tablespace path to convert win32 slashes to unix type of slashes but
>> that is not being passed to strcmp() function and probably that could
>> be the reason why the issue is still existing. Thanks.
>>
>>         for (cell = tablespace_dirs.head; cell; cell = cell->next)
>> -               if (strcmp(dir, cell->old_dir) == 0)
>> +               if (strcmp(canon_dir, cell->old_dir) == 0)
>
> Thanks. I had the correct version on my Windows box actually, just
> messed up the attachment.
> --

Okay. I have once again reviewed your patch and tested it on Windows
as well as Linux. The patch LGTM. I am now marking it as Ready For
Committer. Thanks.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers