Re: [PATCH] Improve geometric types
От | Emre Hasegeli |
---|---|
Тема | Re: [PATCH] Improve geometric types |
Дата | |
Msg-id | CAE2gYzw4K5zVViXDdCKg7ZNY2+47s1gg5Fd4g8xj5a86jQpLSQ@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [PATCH] Improve geometric types (Thomas Munro <thomas.munro@enterprisedb.com>) |
Ответы |
Re: [PATCH] Improve geometric types
|
Список | pgsql-hackers |
> The version number restriction isn't strictly needed. I only > suggested it because it'd match the #if that wraps the code that's > actually using those macros, introduced by commit cec8394b5ccd. That > was presumably done because versions >= 1800 (= Visual Studio 2013) > have their own definitions of isinf() and isnan(), and I guess that > our definitions were probably breaking stuff on that compiler. Now I understand what you mean. win32_port.h defines isnan(x) as _isnan(x) if (_MSC_VER < 1800). It doesn't look right to have the definition in here but not include <float.h> as _isnan() is coming from there. I am preparing an additional patch to add the include and remove it from files where it is obviously put to work around this problem.
В списке pgsql-hackers по дате отправления: