Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently
Дата
Msg-id CAE+jjamcbYSUsyiBgvTgDPXzk+wmWGrtR6OGipVzy_niBgZ1Dg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently
Список pgadmin-hackers
Дерево обсуждения
Hi there,

We weren't able to see these functions get called. Perhaps we're missing something.

Thanks,
Joao && Anthony

On Mon, Apr 30, 2018 at 2:48 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao,

The patches look good however I have noticed that you deleted attachShortcut and attachDialogTabNavigatorShortcut functions from keyboard.js, any specific reason for that?

Thanks,
Khushboo

On Fri, Apr 27, 2018 at 3:11 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Khushboo,

I did some changes on your patch:
 0001 - Your original patch
 0002 - Convert keyboard.js to ES6
 0003 - Refactoring of the keyboard.js file(some one letter variables and other code)



Thanks
Joao

On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM #3284 : F5 key not working consistently.

- Added the configurable keyboard shortcut (default F5) to refresh the browser tree nodes.


Thanks,
Khushboo 

В списке pgadmin-hackers по дате отправления: