Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

Поиск
Список
Период
Сортировка
От Joao Pedro De Almeida Pereira
Тема Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename
Дата
Msg-id CAE+jjam6k_pygmv74o=dubiePTCHmAJi3462VbfofTnTA=P2pA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
Hello Hackers,

@Dave, @Murtuza
We do understand that the changes are tightly coupled with the tree, but if we want to be able to upgrade our tree menu in the future, we need to start decoupling functionality and the underlaying tree.
Another step that we can take is to change our variable naming convention because variables like _d or this.i do not communicate their purpose, making it hard to read.


Thanks
Joao & Shruti

On Wed, May 17, 2017 at 11:05 AM, Dave Page <dpage@pgadmin.org> wrote:


On Wed, May 17, 2017 at 11:41 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Joao,

Yes, this patch is related to browser tree issue, In this patch we have fixed some issues with 'onUpdateTreeNode' function to handle some corner cases for server & server-group nodes, Current code for 'onAddTreeNode', 'onUpdateTreeNode', 'onRefreshTreeNode' functions for browser tree is coupled with their respective inner function calls and recursive in nature due to aciTree API implementation for making function calls in orderly manner.

@Ashesh,
Any thoughts on this?

I'm obviously not Ashesh, but in general, I agree with what Joao suggests - treeview related code should be refactored into testable modules, that are independent of the tree (for the most part) whenever it makes sense to do so, and tests added to aid future replacement of aciTree/Backbone. That said, if it's not feasible in a given case, then we should go ahead and fix the existing code. 

In this case, I'm leaning towards the view that this code is too tightly coupled with aciTree to be worth changing more than necessary. What do you guys think?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Neel Patel
Дата:
Сообщение: [pgadmin-hackers] [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embeddedserver in runtime on Windows
Следующее
От: Shirley Wang
Дата:
Сообщение: Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4