Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum
От | Joao Pedro De Almeida Pereira |
---|---|
Тема | Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum |
Дата | |
Msg-id | CAE+jja=dpFAAxavzJupBjcKQNZjox+grCiqd53AC2EO2G-FGdg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum (Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>) |
Ответы |
Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum
|
Список | pgadmin-hackers |
Thanks for reviewing, Ashesh.
We have updated the patch. The headers are all consistent and we removed the __init__.py files in directories containing only .sql.
Thanks!
Joao & Matt
On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Ashesh,Thanks for reviewing the patch.We added the __init__.py files into templates to convert them into packages so that the tests inside of them can be found by the test runner.Thanks!
Joao & SarahOn Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:Hi Joao & Sarah,Ashesh, can you review/commit this please?On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hi Hackers,We found out that when you are connected to a GreenPlum database and try to get Dependents and Dependencies of an object the application was returning a SQL error.This patch splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple versioned files.Add Unit Tests for each file.Also added __init__.py files to other test directories to run the tests in them.Why do we need to add __init__.py in the template directory?I didn't understand the purpose of the adding __init__.py files in the template directories.NOTE: The headers in those files are not consistent with the other project files.--Add ORDER BY into Copy Selection Feature test to ensure the results are retrieved always in the same orderRenamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it for versions less than 9.1 ThanksJoao & Sarah
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers --Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
В списке pgadmin-hackers по дате отправления: