Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)

2015-01-10 8:18 GMT+09:00 Jim Nasby <Jim.Nasby@bluetreble.com>:
> On 1/6/15, 5:43 PM, Kouhei Kaigai wrote:
>>>>
>>>> scan_relid != InvalidOid
>>>> > >
>>>
>>> >
>>> >Ideally, they should be OidIsValid(scan_relid)
>>> >
>>
>> Scan.scanrelid is an index of range-tables list, not an object-id.
>> So, InvalidOid or OidIsValid() are not a good choice.
>
>
> I think the name needs to change then; scan_relid certainly looks like the
> OID of a relation.
>
> scan_index?
>
Yep, I had a same impression when I looked at the code first time,
however, it is defined as below. Not a manner of custom-scan itself.

/** ==========* Scan nodes* ==========*/
typedef struct Scan
{   Plan        plan;   Index       scanrelid;      /* relid is index into the range table */
} Scan;

-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>