Re: [Code Cleanup] : Small code cleanup in twophase.sql
| От | Nishant Sharma |
|---|---|
| Тема | Re: [Code Cleanup] : Small code cleanup in twophase.sql |
| Дата | |
| Msg-id | CADrsxdaZ84tJ9hu9SSgR-PMDk7X+4LpLV0aQfxpZhVaR0V36_w@mail.gmail.com обсуждение исходный текст |
| Ответ на | [Code Cleanup] : Small code cleanup in twophase.sql (Nishant Sharma <nishant.sharma@enterprisedb.com>) |
| Список | pgsql-hackers |
Hi,
Any taker or rejector for above? -- It's a very small 'good to have' change patch for cleanup.
Thanks,
Nishant (EDB).
On Tue, Sep 26, 2023 at 6:31 PM Nishant Sharma <nishant.sharma@enterprisedb.com> wrote:
Hi,PFA small code cleanup in twophase.sql. Which contains a drop tablestatement for 'test_prepared_savepoint'. Which, to me, appears to bemissing in the cleanup section of that file.To support it I have below points:-1) Grepping this table 'test_prepared_savepoint' shows occurrencesonly in twophase.out & twophase.sql files. This means that table islocal to that sql test file and not used in any other test file.2) I don't see any comment on why this was not added in the cleanupsection of twophase.sql, but drop for other two test tables are done.3) I ran "make check-world" with the patch and I don't see any failures.Kindly correct, if I missed anything.Regards,Nishant (EDB).
В списке pgsql-hackers по дате отправления: