Re: postgres_fdw: wrong results with self join + enable_nestloop off
| От | Nishant Sharma |
|---|---|
| Тема | Re: postgres_fdw: wrong results with self join + enable_nestloop off |
| Дата | |
| Msg-id | CADrsxdY5BmApKSxSEODuswDQL8M1+eY-6R=ZyiyT=PoLOthVOA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: postgres_fdw: wrong results with self join + enable_nestloop off (Etsuro Fujita <etsuro.fujita@gmail.com>) |
| Список | pgsql-hackers |
Looks good to me. Tested on master and it works.
New patch used a bool flag to avoid calls for both FDW and custom hook's call. And a slight change in comment of "has_pseudoconstant_clauses" function.
Regards,
Nishant.
On Wed, Jun 14, 2023 at 12:19 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
On Mon, Jun 5, 2023 at 10:19 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> To avoid this issue, I am wondering if we should modify
> add_paths_to_joinrel() in back branches so that it just disallows the
> FDW to consider pushing down joins when the restrictlist has
> pseudoconstant clauses. Attached is a patch for that.
I think that custom scans have the same issue, so I modified the patch
further so that it also disallows custom-scan providers to consider
join pushdown in add_paths_to_joinrel() if necessary. Attached is a
new version of the patch.
Best regards,
Etsuro Fujita
В списке pgsql-hackers по дате отправления: