Re: Re: Add generate_series(date, date) and generate_series(date, date, integer)
| От | Corey Huinker |
|---|---|
| Тема | Re: Re: Add generate_series(date, date) and generate_series(date, date, integer) |
| Дата | |
| Msg-id | CADkLM=e2-V=HBiuBabpBZTG_A10EkDBjcrma0t6L+cSLPACaGg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Add generate_series(date, date) and generate_series(date, date, integer) (David Steele <david@pgmasters.net>) |
| Ответы |
Re: Re: Add generate_series(date, date) and
generate_series(date, date, integer)
Re: Re: Add generate_series(date, date) and generate_series(date, date, integer) |
| Список | pgsql-hackers |
Doh, I left that comment to myself in there. :)
The corresponding structs in timestamp.c and int.c have no comment, so suggestions of what should be there are welcome. In the interim I put in this:
/* state for generate_series_date(date,date,[step]) */
Extra linefeed after struct removed.
Do you have any insight as to why the documentation test failed?
In the mean time, here's the updated patch.
In the mean time, here's the updated patch.
On Tue, Feb 2, 2016 at 11:41 AM, David Steele <david@pgmasters.net> wrote:
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, failed
Everything looks good except for two minor issues:
1) There should be an informative comment for this struct:
+/* Corey BEGIN */
+typedef struct
+{
+ DateADT current;
+ DateADT stop;
+ int32 step;
+} generate_series_date_fctx;
2) There's an extra linefeed after the struct. Needed?
Regards,
-David
The new status of this patch is: Waiting on Author
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
В списке pgsql-hackers по дате отправления: