Re: Psqlodbc build fails on linux

Поиск
Список
Период
Сортировка
От Dave Cramer
Тема Re: Psqlodbc build fails on linux
Дата
Msg-id CADK3HHKk-ADXc3G6rt38ahpgbDaTpZs+yMrDk_zC0uec2HqmDg@mail.gmail.com
обсуждение исходный текст
Ответ на Psqlodbc build fails on linux  (Moazzum Ali <moazzum.ali@enterprisedb.com>)
Ответы Re: Psqlodbc build fails on linux  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-odbc
Please see attached patch to use autoconf to detect and use stdbool.h 

I have to admit to having no idea if this is correct or if the style is correct, much was copied from postgresql.

I have tested it on ubuntu, and it compiles. 

Dave Cramer
www.postgres.rocks


On Mon, 4 Sept 2023 at 13:56, Moazzum Ali <moazzum.ali@enterprisedb.com> wrote:
Thanks Dave and Michael.

On Mon, Sep 4, 2023, 10:54 PM Dave Cramer <davecramer@postgres.rocks> wrote:
Seems like the better solution is to use Michael's suggestion as that is what PG does.

Dave Cramer
www.postgres.rocks


On Mon, 4 Sept 2023 at 12:28, Moazzum Ali <moazzum.ali@enterprisedb.com> wrote:
Dave,

Is it something that can be fixed on PG or psqlodbc side or you would also suggest what Michael suggested? I have tried that environment rule though and it works.

Thanks,
Moazzum

On Mon, Sep 4, 2023, 9:07 PM Dave Cramer <davecramer@postgres.rocks> wrote:


On Mon, 4 Sept 2023 at 10:23, Dave Cramer <davecramer@postgres.rocks> wrote:


On Sun, 3 Sept 2023 at 19:46, Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Aug 31, 2023 at 06:28:06AM +0500, Moazzum Ali wrote:
> One way to fix the error is to include the following line before
> #include "pqexpbuffer.h" in connection.h and statement.h
> #include <stdbool.h>

Wouldn't it be better to enforce an environment rule in psqlodbc.h
instead?  PostgreSQL enforces PG_USE_STDBOOL already on Windows, and
I am pretty sure that it would be OK to do the same in other *nix
places where anybody cares about ODBC.

I'm guessing this is a debian thing as I just built this successfully on a redhat (ish) system 

It pays to read all of the above before trying to replicate. I was building against 15, not 16
I see the failure now 

Dave
Вложения

В списке pgsql-odbc по дате отправления:

Предыдущее
От: Moazzum Ali
Дата:
Сообщение: Re: Psqlodbc build fails on linux
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: ODBC driver maintenance: PostgreSQL 16 support and other open items