Re: Using defines for protocol characters

On Thu, 3 Aug 2023 at 13:25, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> Greetings,
>
> Attached is a patch which introduces a file protocol.h. Instead of using
> the actual characters everywhere in the code this patch names the
> characters and removes the comments beside each usage.

> +#define DESCRIBE_PREPARED           'S'
> +#define DESCRIBE_PORTAL             'P'

You use these for Close message as well. I don't like the idea because
Close is different message from Describe message.

What about adding following for Close too use them instead?

#define CLOSE_PREPARED           'S'
#define CLOSE_PORTAL             'P'

Good catch. 

I recall when writing this it was a bit hacky.

What do you think of PREPARED_SUB_COMMAND   and PORTAL_SUB_COMMAND instead of duplicating them ?

Dave