Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Поиск
Список
Период
Сортировка
От Dave Cramer
Тема Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
Дата
Msg-id CADK3HHJLedC=bOnQwkSnU3D9GNS4Suqd-1zevd-PuNCqm=bSmw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display  (Violet Cheng <vcheng@pivotal.io>)
Ответы Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display  (Jing Li <jingli@pivotal.io>)
Список pgadmin-hackers
Дерево обсуждения
Hi Violet.

I don't really like the way this has been implemented. It adds a variable which is only used for gpdb.

There are other places in the code where the behaviour is changed if the server is ppas or regular postgres. 

Candidly I think all of this needs restructuring.

Dave Cramer

On 15 August 2017 at 23:29, Violet Cheng <vcheng@pivotal.io> wrote:
Hi,

Any comment on this patch? If no, will it be committed soon?

Thanks,
Violet

On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers!

This patch enables Greenplum users to see the same charts on the dashboard as postgres users. It also adds some additional information to the DDL that is Greenplum specific and necessary to create a new table.

Thanks!
Sarah




В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: pgAdmin4: Random failure of FTS test cases due to improper randomstring creation
Следующее
От: Thomas Krennwallner
Дата:
Сообщение: PATCH: pgagent connection string parsing