Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)

On Tue, Feb 5, 2013 at 12:44 PM, Phil Sorber <phil@omniti.com> wrote:
> On Tue, Feb 5, 2013 at 9:08 AM, Phil Sorber <phil@omniti.com> wrote:
>> On Tue, Feb 5, 2013 at 9:06 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>>> Phil Sorber escribió:
>>>> On Tue, Feb 5, 2013 at 6:41 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>>>> > On Sat, Feb 2, 2013 at 9:55 PM, Phil Sorber <phil@omniti.com> wrote:
>>>> >> OK, here is the patch that handles the connection string in dbname.
>>>> >> I'll post the other patch under a different posting because I am sure
>>>> >> it will get plenty of debate on it's own.
>>>> >
>>>> > I'm sorry, can you remind me what this does for us vs. the existing coding?
>>>> >
>>>>
>>>> It's supposed to handle the connection string passed as dbname case to
>>>> be able to get the right output for host:port.
>>>
>>> Surely the idea is that you can also give it a postgres:// URI, right?
>>
>> Absolutely.
>
> Here is it. I like this approach more than the previous one, but I'd
> like some feedback.
>

Minor adjustment.

> There still seems to be a bit of a disconnect in libpq in my opinion.
> Taking options as a string (URI or conninfo) or a set of arrays, but
> returning info about connection parameters in PQconninfoOption? And
> nothing that takes that as an input. Seems odd to me.
>
>>
>>>
>>> --
>>> Álvaro Herrera                http://www.2ndQuadrant.com/
>>> PostgreSQL Development, 24x7 Support, Training & Services