Re: [PATCH] Relocation of tablespaces in pg_basebackup

Поиск

Список

Период

Сортировка

От	Steeve Lennmark
Тема	Re: [PATCH] Relocation of tablespaces in pg_basebackup
Дата	16 января 2014 г. 17:01:04
Msg-id	CADAK8w4kPfEojBRj7k+rUqYzk112Xc2tvWysgiPXan+-6NvnHA@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [PATCH] Relocation of tablespaces in pg_basebackup (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список	pgsql-hackers

Alvaro,

On Thu, Jan 16, 2014 at 3:25 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

Eyeballing this patch, three thoughts:

1. I wonder whether ilist.c/h should be moved to src/common so that
frontend code could use it.

That would be nice, I guess lack of helpers is why a lot of stuff is

using pgdumputils.h from src/bin/pg_dump.

$ git grep -l dumputils.h src/bin/{psql,scripts}

src/bin/psql/command.c

src/bin/psql/copy.c

src/bin/psql/describe.c

src/bin/scripts/clusterdb.c

src/bin/scripts/createdb.c

src/bin/scripts/createuser.c

src/bin/scripts/dropdb.c

src/bin/scripts/dropuser.c

src/bin/scripts/reindexdb.c

src/bin/scripts/vacuumdb.c

3. How many definitions of atooid() do we have now?

$ git grep '#define atooid' |wc -l

I found no obvious .h to include though.

Steeve Lennmark

В списке pgsql-hackers по дате отправления: