Re: Regression tests fail with musl libc because libpq.so can't be loaded

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: Regression tests fail with musl libc because libpq.so can't be loaded
Дата
Msg-id CAD5tBcJwwTSwKUFkpo-zJSH4Mu1=Q2CsvNgiqJ44AOOAx-jbdA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Regression tests fail with musl libc because libpq.so can't be loaded  (Peter Eisentraut <peter@eisentraut.org>)
Список pgsql-bugs


On Wed, Mar 20, 2024 at 2:03 AM Peter Eisentraut <peter@eisentraut.org> wrote:
On 17.03.24 11:33, Christophe Pettus wrote:
>> On Mar 17, 2024, at 02:44, Wolfgang Walther <walther@technowledgy.de> wrote:
>>
>> Nailed it. PS_USE_NONE fixes it.
>
> Given the musl (still?) does not define a preprocessor macro specific to it, is there a way of improving the test in pg_status.c to catch this case?  It seems wrong that the current test passes a case that doesn't actually work.
>

We could turn it around and do

#if defined(__linux__)
#if defined(__GLIBC__) || defined(__UCLIBC__ )
#define PS_USE_CLOBBER_ARGV
#else
#define PS_USE_NONE
#endif
#endif




I like it. Neat and minimal.

cheers

andrew

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Sawyer Knoblich
Дата:
Сообщение: Re: BUG #18399: Query plan optimization results in runtime error when hoisting cast from inside subquery
Следующее
От: Wolfgang Walther
Дата:
Сообщение: Re: Regression tests fail with musl libc because libpq.so can't be loaded