Re: Skipping logical replication transactions on subscriber side

On Thu, Nov 25, 2021 at 9:08 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Wed, Nov 24, 2021 at 10:44 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > I've attached an updated version patch. Unless I miss something, all
> > comments I got so far have been incorporated into this patch. Please
> > review it.
> >
>
> Only a couple of minor points:
>
> src/backend/postmaster/pgstat.c
> (1) pgstat_get_subworker_entry
>
> In the following comment, it should say "returns an entry ...":
>
> + * apply worker otherwise returns entry of the table sync worker associated
>
> src/include/pgstat.h
> (2) typedef struct PgStat_StatDBEntry
>
> "subworker" should be "subworkers" in the following comment, to match
> the struct member name:
>
> * subworker is the hash table of PgStat_StatSubWorkerEntry which stores
>
> Otherwise, the patch LGTM.

Thank you for the comments! These are incorporated into v25 patch I
just submitted.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/