Re: Make pg_waldump report replication origin ID, LSN, and timestamp.

On Thu, Dec 9, 2021 at 4:02 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Dec 08, 2021 at 05:03:30PM +0900, Masahiko Sawada wrote:
> > Agreed. I've attached an updated patch that incorporated your review
> > comments. Please review it.
>
> That looks correct to me.  One thing that I have noticed while
> reviewing is that we don't check XactCompletionApplyFeedback() in
> xact_desc_commit(), which would happen if a transaction needs to do
> a remote_apply on a standby.  synchronous_commit is a user-settable
> parameter, so it seems to me that it could be useful for debugging?
>

Agreed.

Thank you for updating the patch. The patch looks good to me.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/