Re: Add memory_limit_hits to pg_stat_replication_slots

On Thu, Sep 25, 2025 at 10:26 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi,
>
> On Thu, Sep 25, 2025 at 12:14:04PM -0700, Masahiko Sawada wrote:
> > On Thu, Sep 25, 2025 at 3:17 AM Bertrand Drouvot
> > <bertranddrouvot.pg@gmail.com> wrote:
> > >
> > > That probably means that mem_exceeded_count would need to be increased.
> > >
> > > What do you think?
> >
> > Right. But one might argue that if we increment mem_exceeded_count
> > only when serializing or streaming is actually performed,
> > mem_exceeded_count would be 0 in the first example and therefore users
> > would be able to simply check mem_exceeded_count without any
> > computation.
>
> Right but we'd not be able to see when the memory limit has been reached for all
> the cases (that would hide the aborted transactions case). I think that with
> the current approach we have the best of both world (even if it requires some
> computations).

Agreed. It would be better to show a raw statistic so that users can
use the number as they want.

I've made a small comment change and added the commit message to the
v5 patch. I'm going to push the attached patch barring any objection
or review comments.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com