Re: [PATCH] Add tests for Bitmapset

On Tue, Sep 16, 2025 at 12:04 PM Greg Burd <greg@burd.me> wrote:
>
> I've re-written the set of tests as suggested (I hope!).  I've not
> re-run the coverage report (yet) to ensure we're at least as well
> covered as v3, but attached is v4 for your inspection (amusement?).
> I've tried to author the SQL tests such that failures clearly indicate
> what's at gone wrong.
>
> This exercise turned into a lot more LOC than I'd expected, I hope it
> provides some value to the community for testing this important data
> structure and helps to codify the API clearly.

Thank you for updating the patch. It seems cfbot caught a regression
test error[1] in a 32-bit build.

Regards,

[1] https://cirrus-ci.com/task/5290864655728640

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com